This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
fix: remove node buffers #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to the latest changes from interface-datastore and datastore-core Depends on: - [ ] ipfs/interface-datastore#43 - [ ] ipfs/js-datastore-core#27 BREAKING CHANGES: only uses Uint8Arrays internally
Gozala
approved these changes
Jul 28, 2020
src/index.js
Outdated
| value: buf | ||
| } | ||
| } catch (err) { | ||
| console.info(err) |
There was a problem hiding this comment.
🚨 It looks like this would start swallowing errors, which seems unrelated to Uint8Array change.
📝 Should this be console.error(error) (or console.warn) instead ?
There was a problem hiding this comment.
Oops, no, this shouldn't be in there at all. It's related to a new test added to interface-datastore that mutates the datastore while running a query (a value is deleted). To pass the test we don't have to take the mutation into account but we shouldn't explode either.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the latest changes from interface-datastore and datastore-core
Depends on:
BREAKING CHANGE: only uses Uint8Arrays internally